build: fix zlib tarball generation #32094
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
build
jasnell
approved these changes
Mar 4, 2020
|
I'm going through and testing locally. Will add my explicit +1 when I can confirm this is fixed |
|
I'd like to |
richardlau
approved these changes
Mar 4, 2020
MylesBorins
added
the
fast-track
|
Gotta put my two cents in here and say this still looks like a short-term fix. So long as tarballs are being created after compilation, issues like this will just keep popping up. Would love it if the build could just be changed so that binaries are built off the tarball files, so the build only passes if the tarball is good. |
|
I can confirm that this fixes the build problem AND that we need the entire folder... I aggressively tried to save us 92k to no avail. |
|
Going to go ahead and last this, the failing dgram tests on OSX are known failures |
|
Landed in 2130474 |
MylesBorins
pushed a commit
that referenced
this pull request
Mar 4, 2020
PR-URL: #32094 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Myles Borins <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Mar 4, 2020
PR-URL: #32094 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Myles Borins <[email protected]>
Merged
codebytere
added a commit
that referenced
this pull request
Mar 15, 2020
PR-URL: #32094 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Myles Borins <[email protected]>
codebytere
added a commit
that referenced
this pull request
Mar 17, 2020
PR-URL: #32094 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Myles Borins <[email protected]>
Merged
codebytere
added a commit
that referenced
this pull request
Mar 30, 2020
PR-URL: #32094 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Myles Borins <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #31858.
Ensures that
contrib/optimizationsisn't stripped from the source tree to mitigate build failures e.gI'm not 100% sure we need to include all of
contrib/optimizations, so let me know if there are any changes I'll need to make.cc @MylesBorins @richardlau
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes